Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material: Add missing blend parameters to toJSON(). #26947

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Material: Add missing blend parameters to toJSON(). #26947

merged 1 commit into from
Oct 11, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 11, 2023

Related issue: -

Description

This PR adds missing blend parameters to Material.toJSON(). It also makes sure MaterialLoader honors the new parameters and adds missing checks in toJSON() for existing material properties.
@Mugen87 Mugen87 added this to the r158 milestone Oct 11, 2023
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
649.1 kB (160.9 kB) 650.2 kB (161.2 kB) +1.05 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
442.5 kB (107.1 kB) 443.1 kB (107.2 kB) +667 B
@Mugen87 Mugen87 merged commit 5846367 into mrdoob:dev Oct 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@Mugen87