Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAOPass: Remove depthMaterial reference from dispose(). #26946

Merged
merged 1 commit into from
Oct 11, 2023
Merged

SAOPass: Remove depthMaterial reference from dispose(). #26946

merged 1 commit into from
Oct 11, 2023

Conversation

paradoxxxzero
Copy link
Contributor

Fixes Uncaught TypeError: Cannot read properties of undefined (reading 'dispose') when disposing a SAOPass.

Description

This commit 8c047d6 removes depthMaterial from SAOPass but does not remove the dispose call of it.

This PR removes it.
@paradoxxxzero
Remove dispose() of now removed depthMaterial
6cae597 
Fixes Uncaught TypeError: Cannot read properties of undefined (reading 'dispose')
@Mugen87 Mugen87 added this to the r158 milestone Oct 11, 2023
@Mugen87 Mugen87 merged commit 937edb5 into mrdoob:dev Oct 11, 2023
19 checks passed
@Mugen87 Mugen87 changed the title SAOPass: Remove dispose() of now removed depthMaterial Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@paradoxxxzero @Mugen87