Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material: Fix .needsUpdate + .alphaHash #26900

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Material: Fix .needsUpdate + .alphaHash #26900

merged 1 commit into from
Oct 4, 2023

Conversation

donmccurdy
Copy link
Collaborator

Currently .alphaHash is not included in the program cache key.

Related:
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
649.1 kB (160.9 kB) 649.2 kB (160.9 kB) +26 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
442.4 kB (107 kB) 442.4 kB (107.1 kB) +26 B
@Mugen87 Mugen87 added this to the r158 milestone Oct 4, 2023
@Mugen87 Mugen87 merged commit 8de143f into mrdoob:dev Oct 4, 2023
19 checks passed
@donmccurdy donmccurdy deleted the hotfix/material-alphahash-needsupdate branch October 4, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@donmccurdy @Mugen87