Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicalLightingModel: Modular usage #26885

Merged
merged 2 commits into from
Oct 2, 2023
Merged

PhysicalLightingModel: Modular usage #26885

merged 2 commits into from
Oct 2, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 2, 2023

Related issue: Fixes #26820

Description

All MeshStandard*Material materials were computing iridescence' causing unnecessary extra computation.
I added too MeshPhysical*Material properties flags to modulate the shader in favor of optimization.

new PhysicalLightingModel( false, false, false ); // ( clearcoat, sheen, iridescence )
@sunag sunag added this to the r158 milestone Oct 2, 2023
@sunag sunag marked this pull request as ready for review October 2, 2023 06:44
@sunag sunag mentioned this pull request Oct 2, 2023
Closed
@sunag sunag merged commit 80be9a5 into mrdoob:dev Oct 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag