Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaterialLoader: Avoid creating undefined linewidth property. #26707

Merged
merged 2 commits into from
Sep 12, 2023
Merged

MaterialLoader: Avoid creating undefined linewidth property. #26707

merged 2 commits into from
Sep 12, 2023

Conversation

epreston
Copy link
Contributor

@epreston epreston commented Sep 6, 2023 •
edited
Loading

avoid creating undefined linewidth property on each material loaded.
Ensure match with material.tojson
@epreston
fix: MaterialLoader.parse avoid creating undefined linewidth attribute
72ec58f 
avoid creating undefined linewidth attribute on each material loaded.
@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
647.6 kB (160.8 kB) 647.6 kB (160.8 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
440.9 kB (106.9 kB) 440.9 kB (106.9 kB) +0 B
@Mugen87 Mugen87 added this to the r157 milestone Sep 6, 2023
@Mugen87 Mugen87 merged commit ad1f96b into mrdoob:dev Sep 12, 2023
17 of 18 checks passed
@Mugen87 Mugen87 changed the title fix: MaterialLoader.parse avoid creating undefined linewidth attribute Sep 12, 2023
@epreston epreston deleted the patch-2 branch September 12, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@epreston @Mugen87