Editor: Fixed helpers checkbox also hiding the grid.

mrdoob · Nov 28, 2023 · 116382c · 116382c
1 parent e0d329d
commit 116382c
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/editor/js/Viewport.js b/editor/js/Viewport.js
@@ -37,12 +37,10 @@ function Viewport( editor ) {
 	const camera = editor.camera;
 	const scene = editor.scene;
 	const sceneHelpers = editor.sceneHelpers;
-	let showSceneHelpers = true;
 
 	// helpers
 
 	const grid = new THREE.Group();
-	sceneHelpers.add( grid );
 
 	const grid1 = new THREE.GridHelper( 30, 30, 0x888888 );
 	grid1.material.color.setHex( 0x888888 );
@@ -675,17 +673,18 @@ function Viewport( editor ) {
 
 	} );
 
-	signals.showGridChanged.add( function ( showGrid ) {
+	signals.showGridChanged.add( function ( value ) {
+
+		grid.visible = value;
 
-		grid.visible = showGrid;
 		render();
 
 	} );
 
-	signals.showHelpersChanged.add( function ( showHelpers ) {
+	signals.showHelpersChanged.add( function ( value ) {
 
-		showSceneHelpers = showHelpers;
-		transformControls.enabled = showHelpers;
+		sceneHelpers.visible = value;
+		transformControls.enabled = value;
 
 		render();
 
@@ -760,7 +759,8 @@ function Viewport( editor ) {
 		if ( camera === editor.viewportCamera ) {
 
 			renderer.autoClear = false;
-			if ( showSceneHelpers === true ) renderer.render( sceneHelpers, camera );
+			if ( grid.visible === true ) renderer.render( grid, camera );
+			if ( sceneHelpers.visible === true ) renderer.render( sceneHelpers, camera );
 			if ( vr.currentSession === null ) viewHelper.render( renderer );
 			renderer.autoClear = true;