Fix #1188 #1329
Merged
Fix #1188 #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix to validate-reqchk-byname - not hiding error messages properly when one checkbox is unchecked, producing an eror underneath it, then another checkbox is checked, and the previous error doesn't go away. example: http://jsfiddle.net/aUFe4/1/ Update Form.Validator.Extras.js Bugfix to validate-reqchk-byname - not hiding error messages properly when one checkbox is unchecked, producing an eror underneath it, then another checkbox is checked, and the previous error doesn't go away. example: http://jsfiddle.net/aUFe4/1/ Added feature validate-enforce-onselect-value validate-enforce-onselect-value - enables the user to specify when a select value is selected, to enforce / ignore fields remove some unessential code + tab indent cleanup remove some unessential code + tab indent cleanup
also clean up spaces
|
@anutron this is basically what you had already reviewed plus 1 commit from me adressing what you asked for. If you (or someone else) can review my commit then we can merge this. |
|
Yeah, this is good. Big props to @NTOM on this PR from so long ago. Sorry the project is so slow these days. |
|
Ship it. |
SergioCrisostomo
added a commit
that referenced
this pull request
Oct 27, 2015
Bugfix to validate-reqchk-byname #1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed the existing 4 commits, rebased, and added my own adressing what @anutron pointed out:
.getElements()to get called overnullwhendocument.id()doesn't find a elementcloses #1188