Don't show empty tooltips #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make tooltip hidden on creation
|
@muffinmad nice work! 👍 |
| @@ -170,15 +172,22 @@ this.Tips = new Class({ | |||
| clearTimeout(this.timer); | |||
| this.timer = (function(){ | |||
| this.container.empty(); | |||
|
|
|||
| var showTip = !this.options.hideEmpty; | |||
There was a problem hiding this comment.
Not a blocker for shipping this, but you declare this variable just to reference it once in a conditional; I'd remove this line and reference the option directly on line 186.
arian
pushed a commit
that referenced
this pull request
Feb 16, 2015
Don't show empty tooltips - fixes #1298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make tooltip hidden on creation.
Fixing this issue