Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2687 because Extending Natives makes the document.id/toElement combo stop working. #2688

Closed
wants to merge 2 commits into from
Closed

Fixes #2687 because Extending Natives makes the document.id/toElement combo stop working. #2688

wants to merge 2 commits into from

Conversation

nbish11
Copy link
Contributor

@nbish11 nbish11 commented Dec 31, 2014

@timwienk
Copy link
Member

Very nice, thanks a lot for that!

However, would it be possible to follow the code style as it is in the rest of the code and tests? That is mostly: indented with tabs, a different way of using whitespace around braces and parentheses, and as little abbreviations as necessary (for example just element instead of el).

A quick overview is in the wiki:
https://github.com/mootools/mootools-core/wiki/Syntax-and-Coding-Style-Conventions
@nbish11
Copy link
Contributor Author

nbish11 commented Jan 6, 2015

Sure, I'll do an update tomorrow.
@SergioCrisostomo SergioCrisostomo added this to the 1.5.2 milestone Feb 15, 2015
@SergioCrisostomo SergioCrisostomo changed the title See this issue: https://github.com/mootools/mootools-core/issues/2687 Feb 16, 2015
@arian arian changed the title Fix for #2687 because Extending Natives makes the document.id/toElement combo stop working. Feb 16, 2015
@arian arian closed this in 22c140a Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@nbish11 @timwienk @SergioCrisostomo