Effects: Remove jQuery.fx.interval #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable is meant to represent the `jQuery.fx.interval` value. In a future commit, it's going to be set to `13` and `jQuery.fx.interval` will no longer be defined.
`jQuery.fx.interval` has been deprecated since jQuery 3.0.0 but it has been still used in jQuery code until this change.
mgol
force-pushed
the
fx-interval-removal
branch
from
de8ca2b
to
0ab05d2
Compare
timmywil
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jQuery.fx.intervalhas been deprecated since jQuery 3.0.0 but it has beenstill used in jQuery code until this change.
The PR is divided into two commits. The first one just updates tests to parametrize them by a local
fxIntervalvariable that's supposed to imitatejQuery.fx.interval. The second commit updates the source to removejQuery.fx.intervaland changes the value offxIntervalin tests from 10 to 13 as it's no longer possible to tweak this value which has been done until now.Each of the commits passes tests.
Fixes gh-4018
-12 bytes 🎉
Checklist