-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dimensions: Add offset prop fallback to FF for unreliable TR dimensions
Firefox incorrectly (or perhaps correctly) includes table borders in computed dimensions, but they are the only one. Workaround this by testing for it and falling back to offset properties Fixes gh-4529 Closes gh-4808
- Loading branch information
Showing
4 changed files
with
84 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import document from "../var/document.js"; | ||
import documentElement from "../var/documentElement.js"; | ||
import support from "../var/support.js"; | ||
|
||
( function() { | ||
|
||
var reliableTrDimensionsVal, | ||
div = document.createElement( "div" ); | ||
|
||
// Finish early in limited (non-browser) environments | ||
if ( !div.style ) { | ||
return; | ||
} | ||
|
||
// Support: IE 10 - 11+ | ||
// IE misreports `getComputedStyle` of table rows with width/height | ||
// set in CSS while `offset*` properties report correct values. | ||
// Support: Firefox 70+ | ||
// Only Firefox includes border widths | ||
// in computed dimensions. (gh-4529) | ||
support.reliableTrDimensions = function() { | ||
var table, tr, trStyle; | ||
if ( reliableTrDimensionsVal == null ) { | ||
table = document.createElement( "table" ); | ||
tr = document.createElement( "tr" ); | ||
|
||
table.style.cssText = "position:absolute;left:-11111px;border-collapse:separate"; | ||
tr.style.cssText = "border:1px solid"; | ||
|
||
// Support: Chrome 86+ | ||
// Height set through cssText does not get applied. | ||
// Computed height then comes back as 0. | ||
tr.style.height = "1px"; | ||
div.style.height = "9px"; | ||
|
||
documentElement | ||
.appendChild( table ) | ||
.appendChild( tr ) | ||
.appendChild( div ); | ||
|
||
trStyle = window.getComputedStyle( tr ); | ||
reliableTrDimensionsVal = ( parseInt( trStyle.height, 10 ) + | ||
parseInt( trStyle.borderTopWidth, 10 ) + | ||
parseInt( trStyle.borderBottomWidth, 10 ) ) === tr.offsetHeight; | ||
|
||
documentElement.removeChild( table ); | ||
} | ||
return reliableTrDimensionsVal; | ||
}; | ||
} )(); | ||
|
||
export default support; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters