Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAudioLanguagesAndRoles() in ShakaPlayer returns more than 1 combination for 1 track with accessibility tag #3820

Closed
SeverynLutskiv opened this issue Dec 22, 2021 · 2 comments
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@SeverynLutskiv
Copy link

SeverynLutskiv commented Dec 22, 2021

Have you read the FAQ and checked for duplicate open issues? - Yes

What version of Shaka Player are you using? - shaka-player@3.0.7

What browser and OS are you using? - MacOS, Chrome Version 96.0.4664.110

What did you do?

  • Received a manifest with an audio tract that contains 'Accessibility' tag and 'Role' tag. Then I've used a getAudioLanguagesAndRoles() method from ShakaPlayer class.

What did you expect to happen?

  • I've expected to receive one object per each track, which describes it.

What actually happened?

  • I've received 2 objects containing the same 'language' value and different 'role' values, one of it is a value of 'Role' tag in the audio track, other one is a value of 'Accessibility' tag.

We use it to display audio tracks in UI as a picker, but it returns us 2 objects for 1 audio track, which requires us to make some filtering after the getAudioLanguagesAndRoles() method invocation.

Does shaka player have another API for this?

@SeverynLutskiv SeverynLutskiv added the type: bug Something isn't working correctly label Dec 22, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Dec 22, 2021
@TheModMaker TheModMaker added the priority: P2 Smaller impact or easy workaround label Jan 21, 2022
@avelad avelad modified the milestones: v3.3, v4.1 May 4, 2022
@avelad avelad modified the milestones: v4.1, v4.2 Jun 3, 2022
@avelad avelad modified the milestones: v4.2, v4.3 Aug 17, 2022
@avelad avelad modified the milestones: v4.3, v4.4 Nov 11, 2022
@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad modified the milestones: v4.5, v4.6 Oct 5, 2023
@avelad avelad modified the milestones: v4.6, v5.0 Nov 16, 2023
@avelad avelad modified the milestones: v4.7, v5.0 Dec 4, 2023
@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
@avelad avelad modified the milestones: v4.9, v4.10 May 30, 2024
@avelad avelad modified the milestones: v4.10, v4.11 Jul 1, 2024
@avelad
Copy link
Collaborator

avelad commented Jul 12, 2024

Can you share your stream to see what's happening? I want to see how you declare Accessibility and Role tag to see what we are doing wrong. Thanks!

@avelad avelad added status: waiting on response Waiting on a response from the reporter(s) of the issue component: DASH The issue involves the MPEG DASH manifest format labels Jul 12, 2024
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
4 participants