Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using Symbol.species rather than proxies #228

Open
appsforartists opened this issue Sep 27, 2017 · 1 comment
Open

Consider using Symbol.species rather than proxies #228

appsforartists opened this issue Sep 27, 2017 · 1 comment

Comments

@appsforartists
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/species

This would clean up/DRY out the codebase (proxies is a bit of a hack), and provide a possible extension point for 3rd parties to create new derivations of MotionObservable. _multicast and _remember would use IndefiniteSubjects for multicasting, and return an instance of species subscribed to the subject to ensure callers have operators. The other operators would just use new this[Symbol.species] rather than new MotionObservable.
@appsforartists
Copy link
Member Author

This is basically #194.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@appsforartists