Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium after 1.96 had low performance with GLTF extension CESIUM_primitive_outline #12077

Open
MingFanZhu opened this issue Jul 10, 2024 · 4 comments

Comments

@MingFanZhu
Copy link

What happened?

When load same 3DTile whitch has CESIUM_primitive_outline extension,Cesium after 1.96 shows bad performance.It seems like related to the upgrade of ModelLoader since 1.97.Chrome shows PrimitiveOutlineGenerator.updateAttribute takes too much time.Could you check if there are any issues?
微信图片编辑_20240710135425

Reproduction steps

...

Sandcastle example

No response

Environment

Browser:chrome 126.0.6478.127
CesiumJS Version:1.97
Operating System:windows 10

@ggetz
Copy link
Contributor

ggetz commented Jul 10, 2024

Thanks for the report @MingFanZhu. It's very possible that the refactor from 1.96 affected the performance here.

@MingFanZhu
Copy link
Author

Thank you for your response. Are there any plans to address this issue?

@ggetz
Copy link
Contributor

ggetz commented Jul 11, 2024

@MingFanZhu There are no immediate plans to prioritize this issue at the moment.

If you'd like to add more information about your use case, that may help us prioritize. If you are interesting in contributing, please let us know and we'd be happy to discuss implementation or review a PR. Thanks!

@MingFanZhu
Copy link
Author

I have made code modifications regarding this issue, please review them for appropriateness.
CESIUM_primitive_outline performance #12084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment