Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Entity and Primitive APIs more consistent #12071

Open
s3xysteak opened this issue Jul 9, 2024 · 1 comment
Open

Make Entity and Primitive APIs more consistent #12071

s3xysteak opened this issue Jul 9, 2024 · 1 comment
Labels
category - architecture / api type - enhancement

Comments

@s3xysteak
Copy link
Contributor

Feature

PrimitiveCollection do not export his _primitives, which is a property like the values of EntityCollection.

I think it may be great to unify their APIs as much as possible, although it is not possible to fully unify that.
@ggetz ggetz changed the title Can't access PrimitiveCollection's _primitives. We have some confused difference between APIs of EntityCollection and PrimitiveCollection. Jul 10, 2024
@ggetz ggetz changed the title Make Entity and Primitive APIs more conistant Jul 10, 2024
@ggetz
Copy link
Contributor

ggetz commented Jul 10, 2024

Thanks for the suggestion @s3xysteak! I think it's a fair critique of the current Entity and Primitive API consistency.

This is probably not a high priority immediately, but this issue may be useful for collecting other ideas to more closely align the APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - architecture / api type - enhancement
2 participants
@ggetz @s3xysteak