Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot testing for subtle lighting changes #12065

Open
jjhembd opened this issue Jul 3, 2024 · 0 comments
Open

Add screenshot testing for subtle lighting changes #12065

jjhembd opened this issue Jul 3, 2024 · 0 comments

Comments

@jjhembd
Copy link
Contributor

jjhembd commented Jul 3, 2024

Feature

Changes to the rendering pipeline can result in subtle changes to lighting, especially in models using physically-based rendering. See #10346, where manual testing revealed subtle rendering differences resulting from a refactor of the pipeline.

Catching these changes can be difficult because we need to manually inspect and compare the rendering of a wide range of models. This process would be faster and more robust if we automate it via end-to-end screenshot testing.

Some ideas for these tests:

  1. Render test models without any terrain or imagery in the background. This will make the tests less sensitive to network delays.
  2. Use a very low tolerance for screenshot comparisons. Lighting effects can be subtle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment